he's really struggling at this particular point in his career. he's too big a name to not be a "Leading Man" ... but at the same time, he doesn't seem to possess that most important quality of all of Hollywood's biggest Leading Men --- the ability to play rough. look at Tom Cruise, Mel Gibson, Will Smith, Bruce Willis, Harrison Ford, Brad Pitt, Leo DiCaprio, Matt Damon, Hugh Jackman, Johnny Depp, Tom Hanks, Jude Law, Russel Crowe, even John Travolta, etc etc... they all exude enough "manliness" (at least on screen) to carry a movie on their own; to play the hero. some of Orlando's contemporaries (ie: Ryan Gosling, Heath Ledger) have these characteristics... but Orlando still seems to be trapped somewhere between a hottie college-age guy and an adult man. he doesn't have enough of that masculine quality to make the audience (thus, the studios) believe he can carry an entire film.
SO, my suggestion to him, were i to be his manager, would have been to:
1 - NEVER taken the role of Paris in "Troy". that character is the biggest p*ssy ever and i think that it has 100% damaged Orlando's career.
2 - that being in the past, now he has to find a role where he plays someone really rugged. a flick like Sean Penn's "Into The Wild" could have been perfect. get Orlando in touch with his rugged masculine nature, and away from the pretty-boy sh*t that is making teenage girls swoon but making men mock. find a role for him in a war movie, even a supporting role, a part where he's not the soldier that everyone loves and someone has to save ... but instead where he's the one doing the saving. he's the guy bearing the weight of the plot, the burden of the quest.
these are hard times for him, i think. and i'm sure that he and his agents realize it -- that's why we aren't hearing of any future projects. he's really trying to make the jump into proper Leading Man and it's an extremely fine balance he's going to have to walk along for the next few films, if he wants to come out the other side as a true movie star of the generation.