In my opinion, heels look better than flats with shorts... Unless you have very nice, long, skinny legs, flats will just make your legs look chubbier. Heels will make them look longer and skinnier. But then again, very short and tight shorts, such as hot pants and similar will in most cases just look sluttier with heels.